<html>
<head><meta charset="utf-8"><title>Reviewers for while_let_on_iterator PR? rust-clippy#6966 · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html">Reviewers for while_let_on_iterator PR? rust-clippy#6966</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="233243718"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviewers%20for%20while_let_on_iterator%20PR%3F%20rust-clippy%236966/near/233243718" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html#233243718">(Apr 05 2021 at 23:10)</a>:</h4>
<p>Hey, <a href="https://github.com/rust-lang/rust-clippy/pull/6966">https://github.com/rust-lang/rust-clippy/pull/6966</a> is a pretty big PR and I can't seem to find time to review it, does anyone else want to take over?</p>



<a name="233276774"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviewers%20for%20while_let_on_iterator%20PR%3F%20rust-clippy%236966/near/233276774" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html#233276774">(Apr 06 2021 at 07:21)</a>:</h4>
<p>I would like to try my hands on some reviews, so I would take it if that's okay. I could also hand it over for a final review afterwards <span aria-label="upside down" class="emoji emoji-1f643" role="img" title="upside down">:upside_down:</span></p>



<a name="233360114"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviewers%20for%20while_let_on_iterator%20PR%3F%20rust-clippy%236966/near/233360114" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html#233360114">(Apr 06 2021 at 17:42)</a>:</h4>
<p><span class="user-mention" data-user-id="369415">@xFrednet</span> thank you! and yeah i'll keep an eye out</p>



<a name="233360137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviewers%20for%20while_let_on_iterator%20PR%3F%20rust-clippy%236966/near/233360137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html#233360137">(Apr 06 2021 at 17:42)</a>:</h4>
<p>it's a big PR, try to be thorough :)</p>



<a name="233360455"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviewers%20for%20while_let_on_iterator%20PR%3F%20rust-clippy%236966/near/233360455" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html#233360455">(Apr 06 2021 at 17:45)</a>:</h4>
<p>Thank you for giving me the opportunity, I'll do my best! I've already started running lintcheck and reading into the code <span aria-label="upside down" class="emoji emoji-1f643" role="img" title="upside down">:upside_down:</span></p>



<a name="233366772"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviewers%20for%20while_let_on_iterator%20PR%3F%20rust-clippy%236966/near/233366772" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html#233366772">(Apr 06 2021 at 18:31)</a>:</h4>
<p><span class="user-mention" data-user-id="369415">@xFrednet</span> I'm concerned that if you do not turn yourself upright soon, you will suffer from too much blood pressure in your brain.</p>



<a name="233371242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviewers%20for%20while_let_on_iterator%20PR%3F%20rust-clippy%236966/near/233371242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html#233371242">(Apr 06 2021 at 19:01)</a>:</h4>
<p><span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span> ¿ʇɥƃᴉɹ ɹǝʇʇǝq ǝq plnoɥs sᴉɥʇ ¡ʎɹɹos sdn ˙˙˙ɯɥn ˙˙˙ɥɥO</p>



<a name="233371514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviewers%20for%20while_let_on_iterator%20PR%3F%20rust-clippy%236966/near/233371514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html#233371514">(Apr 06 2021 at 19:03)</a>:</h4>
<p>I actually use the upside down smiley that much that I don't know the text form of the normal one ^^</p>



<a name="233372037"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviewers%20for%20while_let_on_iterator%20PR%3F%20rust-clippy%236966/near/233372037" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html#233372037">(Apr 06 2021 at 19:06)</a>:</h4>
<p>Did you flip your icon or am I upside down now?</p>



<a name="233372360"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviewers%20for%20while_let_on_iterator%20PR%3F%20rust-clippy%236966/near/233372360" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html#233372360">(Apr 06 2021 at 19:09)</a>:</h4>
<p>You're up right, from my perspective <span aria-label="grinning face with smiling eyes" class="emoji emoji-1f601" role="img" title="grinning face with smiling eyes">:grinning_face_with_smiling_eyes:</span></p>



<a name="233559209"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviewers%20for%20while_let_on_iterator%20PR%3F%20rust-clippy%236966/near/233559209" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html#233559209">(Apr 07 2021 at 20:53)</a>:</h4>
<p>Back to the topic of the PR. I've started to review it but it takes some time as expected. I hope to finish it tomorrow, I would ping you in the review <span class="user-mention" data-user-id="132040">@Manish Goregaokar</span> to look over my questions/suggestions if that's okay with you? <span aria-label="upside down" class="emoji emoji-1f643" role="img" title="upside down">:upside_down:</span></p>



<a name="233559668"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Reviewers%20for%20while_let_on_iterator%20PR%3F%20rust-clippy%236966/near/233559668" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Reviewers.20for.20while_let_on_iterator.20PR.3F.20rust-clippy.236966.html#233559668">(Apr 07 2021 at 20:57)</a>:</h4>
<p><span class="user-mention" data-user-id="369415">@xFrednet</span> yeah absolutely, thanks!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>